Skip to content

Conversation

@picandocodigo
Copy link
Member

With this Pull Request, the 8.x branch will be merged into main to follow the 8.x Elasticsearch releases. The previous main code which followed the 7.x releases is now branched into 7.x, which should be used with Elasticsearch 7.x releases.

An 8.0.0.pre release will follow.

Replaces Elasticsearch::Transport with Elastic::Transport
Removes type
Updates option hash/keyword argument expectations
Updates usage of client
I need to understand if we still need MultiModel or if it was based on
the document_type which is no longer a thing in Elasticsearch.
- Adds Ruby 3.0 tests
- Removes Ruby 2.6 and 2.7 tests
sinisterchipmunk and others added 8 commits April 12, 2024 15:47
The goal of ClassMethodsProxy is to avoid polluting the target's namespace,
but it was possible to do this by accident when calling `class_eval` before
ActiveSupport was completely loaded. This test ensures the namespace isn't
polluted, regardless of the load state of ActiveSupport.
ActiveSupport patches Kernel to add `class_eval` but this behavior wasn't
loaded in the test environment. This created a discrepancy between test
and prod, causing tests to fail that should have passed and vice versa.
Fully loading ActiveSupport makes the test environment more accurate.
@picandocodigo picandocodigo added the 8.x 8.x branch to use with Elasticsearch 8.x label Apr 16, 2024
@picandocodigo picandocodigo merged commit 0aedb0d into main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.x 8.x branch to use with Elasticsearch 8.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants